[Lldb-commits] [PATCH] D65230: [CMake] Loosen Python version check and ignore patch version

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 24 23:05:42 PDT 2019


labath added inline comments.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:203-204
+  if (NOT CMAKE_CROSSCOMPILING)
+    # Manually split PYTHON_VERSION_STRING because find_python_libs_windows
+    # doesn't set PYTHON_VERSION_MAJOR or PYTHON_VERSION_MINOR.
+    string(REPLACE "." ";" python_version_list ${PYTHON_VERSION_STRING})
----------------
If this is the only reason, then maybe we could fix find_python_libs_windows to set the relevant variables instead (?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65230/new/

https://reviews.llvm.org/D65230





More information about the lldb-commits mailing list