[Lldb-commits] [PATCH] D65128: [Logging] Replace Log::Printf with LLDB_LOG macro (NFC)

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

Sure, this is okay.



================
Comment at: lldb/source/Expression/IRExecutionUnit.cpp:601
 
   if (log) {
+    LLDB_LOGF(log,
----------------
labath wrote:
> looks like there are some `if(log)`s still remaining. Maybe the `{}` around the printf confused your vim macro?
There will always be some "if (log)" statements.  Whenever consing up the log message involves work, you should always say:

if (log) {
   /// Do expensive work
   LLDB_LOG...
}

Not saying that all the remaining "if (logs)" are for that reason, but then intent is NOT to remove all such statements as they serve a useful purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65128/new/

https://reviews.llvm.org/D65128