[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 24 10:02:13 PDT 2019
jingham added a comment.
In D65165#1598553 <https://reviews.llvm.org/D65165#1598553>, @labath wrote:
> Thanks for responding quickly. LGTM, with one comment..
Don't use checks that assume eLanguageTypeUnknown == 0, that seems really confusing and we don't use that practice anywhere else. Pavel's suggestion seems fine.
CHANGES SINCE LAST ACTION
More information about the lldb-commits