[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

[James Y Knight via Phabricator via lldb-commits]

jyknight added a comment.

In D65123#1596983 <https://reviews.llvm.org/D65123#1596983>, @labath wrote:

> In D65123#1596935 <https://reviews.llvm.org/D65123#1596935>, @teemperor wrote:
>
> > Thanks for restoring this, but I'm a bit confused how this has happened. My original diff <https://reviews.llvm.org/D64992?id=210828> didn't remove these folders, but it seems when I committed the diff via arcanist and `git llvm` it also removed these other folders. I assume `git llvm` is when translating the change to SVN not just removing a folder but also all folders in the same directory?
>
>
> Interesting.. I wouldn't be totally surprised by that as git-llvm does some magic to svn check out only the files/directories that have been modified. Combining that with the different treatment of directories in svn and git (explicit modelling vs. implicit "it exists if it contains a file"), I can see how things might go south in some corner cases like this. But that's just speculation -- I'm generally trying to avoid git-llvm as it is too magical for my taste. Maybe @jyknight or @mehdi_amini can shed more light on this?


Reproduced this bug, and working on a fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65123/new/

https://reviews.llvm.org/D65123