[Lldb-commits] [lldb] r366798 - Fix windows build after r366791

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 23 05:26:09 PDT 2019

Author: labath
Date: Tue Jul 23 05:26:09 2019
New Revision: 366798

URL: http://llvm.org/viewvc/llvm-project?rev=366798&view=rev
Fix windows build after r366791

A side effect of this commit was that it exchanged the order of types
and compile units in the output of SymbolVendor::Dump. A couple of PDB
tests dependened on that to assert the links between the two.

While it wouldn't be too hard to update the tests, the change of
ordering was not something I intended to do with that patch, and is easy
to restore the original order, so I do just that.


Modified: lldb/trunk/source/Symbol/SymbolVendor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/SymbolVendor.cpp?rev=366798&r1=366797&r2=366798&view=diff
--- lldb/trunk/source/Symbol/SymbolVendor.cpp (original)
+++ lldb/trunk/source/Symbol/SymbolVendor.cpp Tue Jul 23 05:26:09 2019
@@ -354,10 +354,12 @@ void SymbolVendor::Dump(Stream *s) {
+    s->PutCString("Types:\n");
+    m_type_list.Dump(s, show_context);
+    s->EOL();
     if (m_sym_file_up)
-    m_type_list.Dump(s, show_context);
     if (Symtab *symtab = GetSymtab())
       symtab->Dump(s, nullptr, eSortOrderNone);

More information about the lldb-commits mailing list