[Lldb-commits] [PATCH] D65135: SymbolVendor: Remove the type list member

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 23 03:05:04 PDT 2019


labath created this revision.
labath added reviewers: clayborg, JDevlieghere, jingham.

Similarly to the compile unit lists, the list of types can also be
managed by the symbol file itself.

Since the only purpose of this list seems to be to maintain an owning
reference to all the types a symbol file has created (items are only
ever added to the list, never retrieved), I remove the passthrough
functions in SymbolVendor and Module. I also tighten the interface of
the function (return a reference instead of a pointer, make it protected
instead of public).


https://reviews.llvm.org/D65135

Files:
  include/lldb/Core/Module.h
  include/lldb/Symbol/SymbolFile.h
  include/lldb/Symbol/SymbolVendor.h
  include/lldb/Symbol/Type.h
  source/API/SBCompileUnit.cpp
  source/Core/Module.cpp
  source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
  source/Symbol/SymbolFile.cpp
  source/Symbol/SymbolVendor.cpp
  source/Symbol/Type.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65135.211268.patch
Type: text/x-patch
Size: 12748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190723/6b4613a5/attachment.bin>


More information about the lldb-commits mailing list