[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 23 01:26:55 PDT 2019

labath added subscribers: jyknight, mehdi_amini.
labath added a comment.

In D65123#1596935 <https://reviews.llvm.org/D65123#1596935>, @teemperor wrote:

> Thanks for restoring this, but I'm a bit confused how this has happened. My original diff <https://reviews.llvm.org/D64992?id=210828> didn't remove these folders, but it seems when I committed the diff via arcanist and `git llvm` it also removed these other folders. I assume `git llvm` is when translating the change to SVN not just removing a folder but also all folders in the same directory?

Interesting.. I wouldn't be totally surprised by that as git-llvm does some magic to svn check out only the files/directories that have been modified. Combining that with the different treatment of directories in svn and git (explicit modelling vs. implicit "it exists if it contains a file"), I can see how things might go south in some corner cases like this. But that's just speculation -- I'm generally trying to avoid git-llvm as it is too magical for my taste. Maybe @jyknight or @mehdi_amini can shed more light on this?




More information about the lldb-commits mailing list