[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

Fri Jul 19 03:46:22 PDT 2019

sgraenitz marked 2 inline comments as done.
sgraenitz added inline comments.

================
Comment at: lldb/trunk/tools/debugserver/source/CMakeLists.txt:50
-
-option(LLDB_NO_DEBUGSERVER "Disable the debugserver target" OFF)
-option(LLDB_USE_SYSTEM_DEBUGSERVER "Use the system's debugserver instead of building it from source (Darwin only)." OFF)
----------------
xiaobai wrote:
> Could we actually preserve `LLDB_NO_DEBUGSERVER`? After pulling this patch down into my tree and modifying my caches, I realize that I never really change or test debugserver and would like to avoid building it at all.
This should be equivalent to `-DLLDB_TOOL_DEBUGSERVER_BUILD=OFF`

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64806/new/

https://reviews.llvm.org/D64806