[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 18 22:05:00 PDT 2019


JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

All uses of this new function drop the error on the ground. Does that mean it doesn't matter? If it does, should we return an expected instead? Should we stop on the first error, or is it fine to overwrite when iterating over `languages_for_expressions`? It seems like the error handling needs some more work here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64964/new/

https://reviews.llvm.org/D64964





More information about the lldb-commits mailing list