[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I know there are a lot of specific notes floating around right now, but two quick suggestions.

I see the idiom

  self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
  target = self.dbg.CreateTarget(exe)

repeated in several places.  They're doing the same thing, doing the second is preferred.

In all? of the test_ methods, you rebuild the test binary.  This can be in the setup method, can't it?

It looks like you've changed to creating your own dylib/solib to test module setting, instead of trying to use a libc function.  Good change, it will make this a lot more portable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64853/new/

https://reviews.llvm.org/D64853