[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

[Alex Langford via Phabricator via lldb-commits]

xiaobai added a comment.

Yes, I agree that replacing ClangASTContext uses with TypeSystem would be the right thing to do, and it's what I plan on doing next. There are instances where you really do want a ClangASTContext (e.g. in plugins related to clang expression parsing and objc), and so having a convenience function like this means you don't have to cast the result of every call. This is similar to `ObjCLanguageRuntime::Get`. I don't mind abandoning this patch though.

Luckily, like you pointed out, most uses of ClangASTContext are very generalizable so it shouldn't be too bad to change things over.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64844/new/

https://reviews.llvm.org/D64844