[Lldb-commits] [PATCH] D64823: [CMake] Default LLDB_PATH_TO_LLVM_BUILD to LLVM_DIR

[Alex Langford via Phabricator via lldb-commits]

xiaobai added inline comments.


================
Comment at: lldb/cmake/modules/LLDBStandalone.cmake:45
   if(CMAKE_CROSSCOMPILING)
     set(LLVM_NATIVE_BUILD "${LLDB_PATH_TO_LLVM_BUILD}/NATIVE")
     if (NOT EXISTS "${LLVM_NATIVE_BUILD}")
----------------
sgraenitz wrote:
> @xiaobai Can this be changed to something like `${LLVM_DIR}/../../../NATIVE`?
Yeah I don't see why not. We could probably even change it to `${LLVM_BINARY_DIR}/NATIVE` instead.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64823/new/

https://reviews.llvm.org/D64823