[Lldb-commits] [lldb] r366350 - [CMake] Avoid liblldb genex when figuring out the copy destination for framework tools

[Stefan Granitz via lldb-commits]

Author: stefan.graenitz
Date: Wed Jul 17 10:14:40 2019
New Revision: 366350

URL: http://llvm.org/viewvc/llvm-project?rev=366350&view=rev
Log:
[CMake] Avoid liblldb genex when figuring out the copy destination for framework tools

This genex created an order-only dependency to liblldb for every framework tool. It reduced build throughput in the first half of the compilation and pulled in unnecessary build units, e.g. debugserver required ~900 build units. With this change debugserver is (again) down at 52 build units!

Modified:
    lldb/trunk/cmake/modules/AddLLDB.cmake

Modified: lldb/trunk/cmake/modules/AddLLDB.cmake
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/AddLLDB.cmake?rev=366350&r1=366349&r2=366350&view=diff
==============================================================================
--- lldb/trunk/cmake/modules/AddLLDB.cmake (original)
+++ lldb/trunk/cmake/modules/AddLLDB.cmake Wed Jul 17 10:14:40 2019
@@ -199,7 +199,8 @@ endfunction()
 function(lldb_add_to_buildtree_lldb_framework name subdir)
   # Destination for the copy in the build-tree. While the framework target may
   # not exist yet, it will exist when the generator expression gets expanded.
-  set(copy_dest "$<TARGET_FILE_DIR:liblldb>/../../../${subdir}")
+  get_target_property(framework_build_dir liblldb LIBRARY_OUTPUT_DIRECTORY)
+  set(copy_dest "${framework_build_dir}/${subdir}")
 
   # Copy into the given subdirectory for testing.
   add_custom_command(TARGET ${name} POST_BUILD