[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

Wed Jul 17 08:24:07 PDT 2019

labath added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:212-215
+
+        module_name = "libsystem_malloc.dylib"
+        if not os_description == "Darwin":
+            module_name = "libc.so"
----------------
davide wrote:
> Something like this will definitely break on Windows (@compnerd), so you probably need to generalize this test or skip it there. Also, what about other platforms, e.g. iOS? (@jasonmolenda)
The best thing to do here is to build a shared library as a part of the test. This way, you can control exactly which symbols are present inside it. There are examples of building shared libraries in the test suite (TestLoadUnload comes to mind..)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64853/new/

https://reviews.llvm.org/D64853