[Lldb-commits] [PATCH] D64853: Fix CommandInterpreter for _regex-break with options

[Davide Italiano via Phabricator via lldb-commits]

davide added subscribers: jasonmolenda, compnerd.
davide added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestRegexpBreakCommand.py:212-215
+
+        module_name = "libsystem_malloc.dylib"
+        if not os_description == "Darwin":
+            module_name = "libc.so"
----------------
Something like this will definitely break on Windows (@compnerd), so you probably need to generalize this test or skip it there. Also, what about other platforms, e.g. iOS? (@jasonmolenda)


================
Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:17
     var++;
+    malloc(sizeof(int));
     return 0; // Set break point at this line.
----------------
Not that it matters a lot, but I would free this memory before returning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64853/new/

https://reviews.llvm.org/D64853