[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz marked 3 inline comments as done.
sgraenitz added inline comments.


================
Comment at: lldb/CMakeLists.txt:94
-  endif()
-
   if(TARGET lldb-mi)
----------------
The target will always exist now. The dependency would now depend on `LLDB_USE_SYSTEM_DEBUGSERVER` and set in `lldb/test/CMakeLists.txt`.


================
Comment at: lldb/tools/debugserver/source/CMakeLists.txt:86
 set(LLDB_CODESIGN_IDENTITY "" CACHE STRING
-    "Override code sign identity for debugserver and for use in tests; falls back to LLVM_CODESIGNING_IDENTITY if set or lldb_codesign otherwise (Darwin only)")
-
-# Determine which identity to use and store it in the separate cache entry.
-# We will query it later for LLDB_TEST_COMMON_ARGS.
-if(LLDB_CODESIGN_IDENTITY)
-  set(LLDB_CODESIGN_IDENTITY_USED ${LLDB_CODESIGN_IDENTITY} CACHE INTERNAL "" FORCE)
-elseif(LLVM_CODESIGNING_IDENTITY)
-  set(LLDB_CODESIGN_IDENTITY_USED ${LLVM_CODESIGNING_IDENTITY} CACHE INTERNAL "" FORCE)
-else()
-  set(LLDB_CODESIGN_IDENTITY_USED lldb_codesign CACHE INTERNAL "" FORCE)
-endif()
+    "Identity override for debugserver; see 'Code Signing on macOS' in the documentation (Darwin only)")
 
----------------
The option may move to `LLDBConfig.cmake`? Actually, it affects not only the debugserver target, but also test configuration.


================
Comment at: lldb/tools/debugserver/source/CMakeLists.txt:258
   endif()
-endif()
+#endif()
----------------
Removing the `if() ... endif()` would bloat the diff even more. Would do it in a follow-up NFC commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64806/new/

https://reviews.llvm.org/D64806