[Lldb-commits] [PATCH] D61333: [ASTImporter] Fix LLDB lookup in transparent ctx and with ext src

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 15 13:45:21 PDT 2019


shafik added a comment.

This LGTM now but I will wait for @teemperor to take a look at it.



================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:620
 
     if (predicate(decl->getKind())) {
       if (log) {
----------------
I think a comment on the `predicate` would be helpful as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61333/new/

https://reviews.llvm.org/D61333





More information about the lldb-commits mailing list