[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

David Tenty via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 12 15:27:27 PDT 2019


daltenty marked 6 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/utils/lit/lit/util.py:426
 
+def killProcessAndChildrenIsSupported(llvm_config):
+    """
----------------
delcypher wrote:
> I don't really like how we're now coupling this function with the `LitConfig` object just so we can print out the text `Found python psutil module`. Do we actually need to print out that message? If the tests don't rely on this I either suggest we remove this.
I don't really think it's necessary, this was just to mimic the previous behavior. I will remove it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64251/new/

https://reviews.llvm.org/D64251





More information about the lldb-commits mailing list