[Lldb-commits] [PATCH] D64647: [lldb] [Process/NetBSD] Implement per-thread execution control
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 12 11:27:47 PDT 2019
labath added a comment.
In D64647#1583178 <https://reviews.llvm.org/D64647#1583178>, @mgorny wrote:
> In D64647#1583125 <https://reviews.llvm.org/D64647#1583125>, @labath wrote:
> > Shouldn't there be some tests that come along with this patch?
> I was actually hoping that the test suite already covers what needs to be covered, and buildbot would tell me which tests were fixed ;-).
That is possible, though it would be good to know that before landing the patch. But I would expect that at least some aspect of this functionality is not covered by existing tests (e.g. the handling of multiple concurrent signals).
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:354
+ if (signal != LLDB_INVALID_SIGNAL_NUMBER && signal != action->signal)
+ return Status("NetBSD does not support passing multiple signals simultaneously");
Is this "passing multiple signals simultaneously", or "passing multiple *distinct* signals simultaneously". (E.g,. thread 1 gets a SIGALRM, thread 2 gets SIGIO, etc.).
CHANGES SINCE LAST ACTION
More information about the lldb-commits