[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 11 16:07:52 PDT 2019


xiaobai added a comment.

In D64591#1581820 <https://reviews.llvm.org/D64591#1581820>, @jingham wrote:

> Then the IRDynamicCheck part would go with LLVMUserExpression, and the C-specific checks in Clang...


Except IRDynamicChecks has special knowledge of the clang-specific instrumenters. I can think of another way in which DynamicCheckerFunctions and IRDynamicChecks are more generic classes that will work with any language. I can try to explore that option to see what I come up with, maybe the end result will be better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64591/new/

https://reviews.llvm.org/D64591





More information about the lldb-commits mailing list