[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

This is a little unclear to me.  LLVMUserExpression is the class that represents "anything that uses LLVM at its back end."  Both the Swift & Clang user expressions are instances of this.  Running through IR and inserting little callouts is an LLVMUserExpression type thing.  So it seems like this move is in the right direction, but to be really clean needs to represent LLVMUserExpression in the Plugin Hierarchy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64591/new/

https://reviews.llvm.org/D64591