[Lldb-commits] [PATCH] D64591: [Expression] Move IRDynamicChecks to ClangExpressionParser

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:19
+
+/// \class DynamicCheckerFunctions DynamicCheckerFunctions.h
+/// "lldb/Expression/DynamicCheckerFunctions.h" Encapsulates dynamic check
----------------
Can we skip this boilerplate? 


================
Comment at: include/lldb/Expression/DynamicCheckerFunctions.h:27
+///
+/// a = *b;     // check that b is a valid pointer [b init];   // check that b
+/// is a valid object to send "init" to
----------------
Reflow comment.


================
Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:1307
+                process->GetDynamicCheckers())) {
 
+          IRDynamicChecks ir_dynamic_checks(*checker_funcs,
----------------
Spurious newline?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64591/new/

https://reviews.llvm.org/D64591