[Lldb-commits] [PATCH] D64535: Add convenience methods to convert LLDB to LLVM data structures.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Just wondering if we want to cache the llvm::DWARFContext in the LLDB DWARFContext. See inline comments.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h:69
+
+  std::unique_ptr<llvm::DWARFContext> GetAsLLVM() const;
 };
----------------
Should we cache this lldb's DWARFContext and just hand out a pointer or reference that is owned by this class? Or are we ok creating temp llvm::DWARFContext objects that we will throw away? Is there any state in llvm::DWARFContext that we wouldn't want to re-create or parse is my main concern.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64535/new/

https://reviews.llvm.org/D64535