[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 10 11:00:20 PDT 2019
teemperor marked an inline comment as done.
teemperor added inline comments.
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223
+ // Returns true if this is the last token we get from the lexer.
+ exit = lex.LexFromRawLexer(token);
> Can we write this as `while(!lex.LexFromRawLexer(token))`?
LexFromRawLexer seems to return `true` when the current result is the last token (but still a valid token), so I think no :(
CHANGES SINCE LAST ACTION
More information about the lldb-commits