[Lldb-commits] [lldb] r365527 - [lldb-suite] Skip TestMachCore on Windows

[Stella Stamenova via lldb-commits]

Author: stella.stamenova
Date: Tue Jul  9 11:18:02 2019
New Revision: 365527

URL: http://llvm.org/viewvc/llvm-project?rev=365527&view=rev
Log:
[lldb-suite] Skip TestMachCore on Windows

This test was originally marked as expected failure on Windows, but it is timing out instead of outright failing now. The expectedFailure attribute does not correctly track timeouts (as in, they don't count as failures), so now this is causing the test suite to fail.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py?rev=365527&r1=365526&r2=365527&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/mach-core/TestMachCore.py Tue Jul  9 11:18:02 2019
@@ -26,7 +26,10 @@ class MachCoreTestCase(TestBase):
         lldb.DBG.SetSelectedPlatform(self._initial_platform)
         super(MachCoreTestCase, self).tearDown()
 
-    @expectedFailureAll(bugnumber="llvm.org/pr37371", hostoslist=["windows"])
+    # This was originally marked as expected failure on Windows, but it has
+    # started timing out instead, so the expectedFailure attribute no longer
+    # correctly tracks it: llvm.org/pr37371
+    @skipIfWindows
     def test_selected_thread(self):
         """Test that the right thread is selected after a core is loaded."""
         # Create core form YAML.