[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/trunk/source/Core/Debugger.cpp:1652
+    } else {
+      LLDB_LOG(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST),
+               "failed to launch host thread: {}",
----------------
I'm sorry to be such a nag, but this is incorrect for two reasons:
- this won't clear the error object if logging is disabled. There's an LLDB_LOG_ERROR macro to handle that correctly.
- llvm::formatv does not accept `{}` as a format argument. You need to use `{0}` instead.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64163/new/

https://reviews.llvm.org/D64163