[Lldb-commits] [PATCH] D64163: Change LaunchThread interface to return an expected.

[Michał Górny via Phabricator via lldb-commits]

mgorny added a comment.

This seems to have broken the build for us:
http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20658

  FAILED: tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Host.cpp.o 
  /usr/bin/g++  -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -DLLDB_CONFIGURATION_RELEASE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/lldb/source/Host -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/Host -Itools/lldb/include -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/include -Iinclude -I/home/motus/netbsd8/netbsd8/llvm/include -I/usr/pkg/include/python2.7 -I/home/motus/netbsd8/netbsd8/llvm/tools/clang/include -Itools/lldb/../clang/include -I/usr/pkg/include/libxml2 -I/home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG    -fno-exceptions -fno-rtti -MD -MT tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Host.cpp.o -MF tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Host.cpp.o.d -o tools/lldb/source/Host/CMakeFiles/lldbHost.dir/common/Host.cpp.o -c /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/Host/common/Host.cpp
  /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/Host/common/Host.cpp: In static member function 'static lldb_private::HostThread lldb_private::Host::StartMonitoringChildProcess(const MonitorChildProcessCallback&, lldb::__pid_t, bool)':
  /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/Host/common/Host.cpp:115:72: error: no matching function for call to 'lldb_private::ThreadLauncher::LaunchThread(char [256], void* (&)(void*), MonitorInfo*&, std::nullptr_t)'
         thread_name, MonitorChildProcessThreadFunction, info_ptr, nullptr);
                                                                          ^
  In file included from /home/motus/netbsd8/netbsd8/llvm/tools/lldb/source/Host/common/Host.cpp:57:0:
  /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Host/ThreadLauncher.h:23:3: note: candidate: static llvm::Expected<lldb_private::HostThread> lldb_private::ThreadLauncher::LaunchThread(llvm::StringRef, lldb::thread_func_t, lldb::thread_arg_t, size_t)
     LaunchThread(llvm::StringRef name, lldb::thread_func_t thread_function,
     ^
  /home/motus/netbsd8/netbsd8/llvm/tools/lldb/include/lldb/Host/ThreadLauncher.h:23:3: note:   no known conversion for argument 4 from 'std::nullptr_t' to 'size_t {aka long unsigned int}'
  At global scope:
  cc1plus: warning: unrecognized command line option '-Wno-vla-extension'
  cc1plus: warning: unrecognized command line option '-Wno-deprecated-register'


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64163/new/

https://reviews.llvm.org/D64163