[Lldb-commits] [PATCH] D64154: [Docs] Unify build instructions

Thu Jul 4 23:05:04 PDT 2019

labath added inline comments.

================
Comment at: lldb/docs/resources/build.rst:17
+* `Clang <http://clang.llvm.org/get_started.html>`_
+
+The following requirements are shared on all platforms.
----------------
Should we also mention lld somewhere?
Lld is a hard requirement for running tests on windows. On other platforms lld is not a hard requirement, but having it around will cause some additional tests to be run...

================
Comment at: lldb/docs/resources/build.rst:167-170
+Current stable NetBSD release doesn't ship with libpanel(3), therefore it's
+required to disable curses(3) support with the
+``-DLLDB_DISABLE_CURSES:BOOL=TRUE`` option. To make sure check if
+``/usr/include/panel.h`` exists in your system.
----------------
@mgorny: Maybe you are interested in changing the build scripts so that this is the default when targetting netbsd?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64154/new/

https://reviews.llvm.org/D64154