[Lldb-commits] [lldb] r364669 - [GDBRemote] Remove code that flushes GDB remote packets

[Ed Maste via lldb-commits]

On Fri, 28 Jun 2019 at 14:14, Jonas Devlieghere via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: jdevlieghere
> Date: Fri Jun 28 11:14:27 2019
> New Revision: 364669
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364669&view=rev
> Log:
> [GDBRemote] Remove code that flushes GDB remote packets
>
> The arbitrary timeout when flushing GDB remote packets caused
> non-determinism and flakiness between test runs. I suspect it is what's
> causing the flakiness of the reproducer tests on GreenDragon, and want
> to see if removing it causes that to go away.
>
> This change was originally introduced in r197579 to discard a
> `$T02thread:01;#4` that QEMU was sending. If anybody knows how to test
> that this continues working after removing this code, I'd love to hear
> it.

I believe it's just something like:

$ qemu-system-x86_64 -s -S -snapshot -hda <image file>

then in lldb
(lldb) log enable gdb-remote packets
(lldb) gdb-remote localhost:1234