[Lldb-commits] [PATCH] D64013: Correctly use GetLoadedModuleList to take advantage of libraries-svr4

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 1 11:46:14 PDT 2019

labath added inline comments.

Comment at: lldb/include/lldb/Target/Process.h:684
+  ///    A status object indicating if the operation was sucessful or not.
+  virtual Status LoadModules() { return Status("Not implemented"); }
aadsm wrote:
> labath wrote:
> > Since you're already changing the signature, let's make this return an llvm::Error.
> Ah yeah ok. It still weirds me out that an Error object might not be an error. In this regard I actually much prefer the Status object as it much better conveys the meaning of the return object. Is the plan to move from Status to Error in lldb?
Yep. lldb_private::Status used to be called lldb_private::Error, but it was renamed to avoid confusing with the llvm version.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list