[Lldb-commits] [lldb] r364826 - [lldb] [lldbsuite] Use a unique class name for TestBacktraceAll

Stella Stamenova via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 1 11:13:21 PDT 2019


Author: stella.stamenova
Date: Mon Jul  1 11:13:20 2019
New Revision: 364826

URL: http://llvm.org/viewvc/llvm-project?rev=364826&view=rev
Log:
[lldb] [lldbsuite] Use a unique class name for TestBacktraceAll

It looks like when this test was added, it was based on TestBreakAfterJoin and it ended up with the same class name. This is an issue because the logs associated with the tests use the class name as the identifier for the file and if two tests have the same name their logs overwrite each other. On non-windows, this just means we lose one of the logs, but on Windows this means that one of the tests will fail occasionally because the file are locked by the other test.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/TestBacktraceAll.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/TestBacktraceAll.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/TestBacktraceAll.py?rev=364826&r1=364825&r2=364826&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/TestBacktraceAll.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/backtrace_all/TestBacktraceAll.py Mon Jul  1 11:13:20 2019
@@ -11,7 +11,7 @@ from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
-class BreakpointAfterJoinTestCase(TestBase):
+class BacktraceAllTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 




More information about the lldb-commits mailing list