[Lldb-commits] [PATCH] D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint

Mon Jul 1 07:47:41 PDT 2019

krytarowski accepted this revision.
krytarowski added inline comments.

================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:250
+    if (!thread) {
+      LLDB_LOG(log,
+               "thread not found in m_threads, pid = {0}, LWP = {1}",
----------------
We should always have a fallback and whenever we register an event for an unknown thread, we shall create it in place. There are potential races in the kernel that might lead to this order of reporting events. This is less likely for DB Registers, but still we shall be prepared for it just in case.

I'm fine to leave this for later once we will handle debuggees with multiple threads.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63791/new/

https://reviews.llvm.org/D63791