[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I've also reverted the preceeding patch in this series as reverting this one has caused one of the other tests to start failing (I've tried to make a more surgical fix first, but @jankratochvil pointed out that this basically reintroduced the problem that we were trying  to solve by reverting this).

If I understand correctly the problem correctly, the issue is that the svr4 support on the client side is broken right now, and enabling svr4 on the server exposes that problem. If so, then it seems to me that the best course of action here is:

- introduce a setting which controls whether the client uses svr4 (`plugin.process.gdb-remote.use.svr4` ?). Have it default to false
- reapply the preceeding patch with all fixes (i.e., revert rL364751 <https://reviews.llvm.org/rL364751>)
- reapply this patch
- fix svr4 clientside (either D63868 <https://reviews.llvm.org/D63868> or D62504 <https://reviews.llvm.org/D62504>). This patch can also flip the new setting to true, or it can be done as a followup

Originally, I was going to suggest hard-disabling the client support as step 1, but now I think a setting is a better option because:

- it will enable people to work around svr4 issues if they happen to encounter them in the future
- (my favourite) it will enable to test the non-svr4 code path without needing to rebuild with xml support disabled
- it will enable people to *enable* svr4 support if it happened to work for them (in conjunction with a custom server, I guess) while steps 2--4 are underway

WDYT?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62503/new/

https://reviews.llvm.org/D62503