[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

[Pavel Labath via Phabricator via lldb-commits]

labath resigned from this revision.
labath added a comment.

Besides picking at code style details, I don't believe I have anything useful to add here. :)



================
Comment at: source/Plugins/Language/ObjC/ObjCLanguage.cpp:939-941
+            auto types =
+                decl_vendor->FindTypes(name, /*max_matches*/ UINT32_MAX);
+            for (auto type : types) {
----------------
I don't think using auto is helpful here -- we have many classes to represent "types", and it's not clear that this is talking about CompilerType. If you want to shorten this, I'd suggest folding the FindTypes call into the for loop:
`for (const CompilerType &type : decl_vendor->FindTypes(...))`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63853/new/

https://reviews.llvm.org/D63853