[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 28 10:23:59 PDT 2019


jingham added a comment.

This looks good to me.  I wonder if the SymbolContextScope -> Language calculation that you do in IsRuntimeSupportValue should really be done in SymbolContextScope?  If that's going to be the policy for going from SymbolContextScope, maybe centralize it there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63240/new/

https://reviews.llvm.org/D63240





More information about the lldb-commits mailing list