[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 27 12:36:04 PDT 2019

jankratochvil added a comment.

In D63540#1558347 <https://reviews.llvm.org/D63540#1558347>, @clayborg wrote:

> I am saying to leave symbols with zero size as is _if_ there is another symbol that does have a valid size with the same start address.

This is what this patch does.

> Exactly. The best solution in my mind is:
> - leave all symbols with sizes as is

This is what this patch does.

> - only set a symbol size if there is no other symbol at that address that didn't originally have a size

This is what this patch does.

> - maybe leave zero sizes symbols out of the lookup map if they have no sizes after doing the two steps above

I did not change this, IIUC it is already solved in existing code because `InitAddressIndexes` will expand any such zero-sized symbols first and it already uses the sized symbol in preference to the sizeless one during lookup.




More information about the lldb-commits mailing list