[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

[Raphael Isemann via Phabricator via lldb-commits]

teemperor marked an inline comment as done.
teemperor added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:211
                           "SDKs/MacOSX%u.%u.sdk",
-                          xcode_contents_path.c_str(), versions[0],
-                          versions[1]);
+                          xcode_contents_path.c_str(), versions->at(0),
+                          versions->at(1));
----------------
aprantl wrote:
> For my own education, why is this preferred over `versions[0]`? Because of Optional's `operator->`?
Yeah, just preferred that style to `(*versions)[0]` :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61233/new/

https://reviews.llvm.org/D61233