[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 24 17:44:48 PDT 2019

xiaobai marked an inline comment as done.
xiaobai added inline comments.

Comment at: include/lldb/Target/LanguageRuntime.h:157
+  virtual bool IsRuntimeSupportValue(ValueObject &valobj) {
+    return valobj.GetVariable() && valobj.GetVariable()->IsArtificial();
+  }
aprantl wrote:
> I think this function should not be part of LanguageRuntime any more since there is nothing runtime-specific about it any more.Instead, it should probably be a function implemented by ValueObjectVariable. The Whitelist make still sense in the runtime of course.
I think you're right. No LanguageRuntime currently overrides this and ValueObject uses this anyway as a fallback. If any language runtime needs to implement this kind of behavior, we can add it back at that time.



More information about the lldb-commits mailing list