[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

[Pavel Labath via Phabricator via lldb-commits]

labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:77
+            llvm::dyn_cast<DWARFCompileUnit>(debug_info->GetUnitAtIndex(i))) {
+      if (cu)
+        return nullptr;
----------------
JDevlieghere wrote:
> Is this here to ensure that there's no two candidates? Initially I was pretty confused by this, I think it's worth a comment. 
Yes, that's it. If you know of a nicer way to implement that search, I'd like to hear it. For now, I've just put some comments around this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63643/new/

https://reviews.llvm.org/D63643