[Lldb-commits] [PATCH] D63643: DWARF: Add support for type units+split dwarf combo

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 21 14:25:13 PDT 2019


JDevlieghere added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:77
+            llvm::dyn_cast<DWARFCompileUnit>(debug_info->GetUnitAtIndex(i))) {
+      if (cu)
+        return nullptr;
----------------
Is this here to ensure that there's no two candidates? Initially I was pretty confused by this, I think it's worth a comment. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63643/new/

https://reviews.llvm.org/D63643





More information about the lldb-commits mailing list