[Lldb-commits] [PATCH] D63622: [Target] Hoist LanguageRuntime::GetDeclVendor

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 21 13:04:28 PDT 2019


xiaobai marked an inline comment as done.
xiaobai added inline comments.


================
Comment at: source/API/SBTarget.cpp:1851
+    if (ProcessSP process_sp = target_sp->GetProcessSP()) {
+      for (auto *runtime : process_sp->GetLanguageRuntimes()) {
+        if (auto vendor = runtime->GetDeclVendor()) {
----------------
compnerd wrote:
> Can this not be `const auto *runtime`?
Not unless GetDeclVendor is marked as const as well, and if what Jim says is correct, then we cannot do this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63622/new/

https://reviews.llvm.org/D63622





More information about the lldb-commits mailing list