[Lldb-commits] [PATCH] D63622: [Target] Hoist	LanguageRuntime::GetDeclVendor
    Jim Ingham via Phabricator via lldb-commits 
    lldb-commits at lists.llvm.org
       
    Fri Jun 21 10:35:52 PDT 2019
    
    
  
jingham added inline comments.
================
Comment at: include/lldb/Target/LanguageRuntime.h:137
 
+  virtual DeclVendor *GetDeclVendor() { return nullptr; }
+
----------------
compnerd wrote:
> Can this not be `const`?  Seems like retrieving the vendor should not mutate the runtime.
The vendor is computed lazily, so calling this could cause the vendor to get built.  So formally this is not a const operation.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63622/new/
https://reviews.llvm.org/D63622
    
    
More information about the lldb-commits
mailing list