[Lldb-commits] [PATCH] D63610: [lldb] [Process] Introduce common helpers to split/recombine YMM data

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

It's not much, but it definitely does help.

> // NB: I have no clue why FreeBSD code claims to belong in 'POSIX', and Linux does not.

I think that somehow fell out of the fact that FreeBSD uses an in-process debugging plugin, while linux uses lldb-server.



================
Comment at: lldb/source/Plugins/Process/Utility/RegisterContext_x86.h:357
+// Convenience function to combine YMM register data from XSAVE-style input.
+inline YMMReg XStateToYMM(const void* xmm_bytes, const void* ymm_bytes) {
+  YMMReg ret;
----------------
maybe call the last arg `ymmh_bytes` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63610/new/

https://reviews.llvm.org/D63610