[Lldb-commits] [lldb] r363999 - Revert "Fix a crash in option parsing."

[Davide Italiano via lldb-commits]

Author: davide
Date: Thu Jun 20 16:44:37 2019
New Revision: 363999

URL: http://llvm.org/viewvc/llvm-project?rev=363999&view=rev
Log:
Revert "Fix a crash in option parsing."

This fails on the bots around 1/10 of the time.

Removed:
    lldb/trunk/lit/Driver/Inputs/process_attach_pid.in
    lldb/trunk/lit/Driver/TestProcessAttach.test
Modified:
    lldb/trunk/source/Interpreter/Options.cpp

Removed: lldb/trunk/lit/Driver/Inputs/process_attach_pid.in
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Driver/Inputs/process_attach_pid.in?rev=363998&view=auto
==============================================================================
--- lldb/trunk/lit/Driver/Inputs/process_attach_pid.in (original)
+++ lldb/trunk/lit/Driver/Inputs/process_attach_pid.in (removed)
@@ -1 +0,0 @@
-process attach --pid

Removed: lldb/trunk/lit/Driver/TestProcessAttach.test
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/Driver/TestProcessAttach.test?rev=363998&view=auto
==============================================================================
--- lldb/trunk/lit/Driver/TestProcessAttach.test (original)
+++ lldb/trunk/lit/Driver/TestProcessAttach.test (removed)
@@ -1,2 +0,0 @@
-# RUN: %lldb -x -b -S %S/Inputs/process_attach_pid.in 2>&1 | FileCheck %s
-# CHECK: requires an argument

Modified: lldb/trunk/source/Interpreter/Options.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Interpreter/Options.cpp?rev=363999&r1=363998&r2=363999&view=diff
==============================================================================
--- lldb/trunk/source/Interpreter/Options.cpp (original)
+++ lldb/trunk/source/Interpreter/Options.cpp Thu Jun 20 16:44:37 2019
@@ -1362,12 +1362,6 @@ llvm::Expected<Args> Options::Parse(cons
     int long_options_index = -1;
     val = OptionParser::Parse(argv.size(), &*argv.begin(), sstr.GetString(),
                               long_options, &long_options_index);
-
-    if ((size_t)OptionParser::GetOptionIndex() > argv.size()) {
-      error.SetErrorStringWithFormat("option requires an argument");
-      break;
-    }
-
     if (val == -1)
       break;