[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

[Don Hinton via Phabricator via lldb-commits]

hintonda added inline comments.


================
Comment at: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt:16
+else()
+  target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
+endif()
----------------
I'm assuming from your comment, that this is a performance issue.  If so, could you add a comment and also update the commit message so people can appreciate the need for the added complexity?

Btw, just tested with 3.4.3, and your change made cmake happy.  Thanks!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63544/new/

https://reviews.llvm.org/D63544