[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

Thanks for the initiative! Three inline comments for cosmetics.



================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:143
          PYTHONLIBS_VERSION_STRING "${python_version_str}")
-    message("-- Found Python version ${PYTHONLIBS_VERSION_STRING}")
+    message(STATUS "-- Found Python version ${PYTHONLIBS_VERSION_STRING}")
     string(REGEX REPLACE "([0-9]+)[.]([0-9]+)[.][0-9]+" "python\\1\\2" PYTHONLIBS_BASE_NAME "${PYTHONLIBS_VERSION_STRING}")
----------------
`STATUS` messages are automatically prefixed with `-- ` so it can be removed from the text here.


================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:187
+  message(STATUS "-- LLDB Found PythonDLL: ${PYTHON_DLL}")
+  message(STATUS "-- LLDB Found PythonIncludeDirs: ${PYTHON_INCLUDE_DIR}")
 endfunction(find_python_libs_windows)
----------------
Same as above. Please remove `-- `.


================
Comment at: lldb/cmake/modules/LLDBStandalone.cmake:98
   else()
-    message("-- Found PythonInterp: ${PYTHON_EXECUTABLE}")
+    message(STATUS "-- Found PythonInterp: ${PYTHON_EXECUTABLE}")
   endif()
----------------
Same as above. Please remove `-- `.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370