[Lldb-commits] [PATCH] D63322: DWARF: Avoid storing DIERefs in long-lived containers

[Pavel Labath via Phabricator via lldb-commits]

labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2970
 
   if (die) {
     TypeSystem *type_system =
----------------
aprantl wrote:
> If you find the time:
> 
> ```
> if (!die)
>   return {};
> auto *type_system = GetTypeSystemForLanguage(die.GetCU()->GetLanguageType());
> if (!type_system)
>   return {};
>  DWARFASTParser *dwarf_ast = type_system->GetDWARFParser();
> if (!dwarf_ast)
>   return {};
> ```
Sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63322/new/

https://reviews.llvm.org/D63322