[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

Sun Jun 16 13:22:16 PDT 2019

hintonda added inline comments.

================
Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12
+
+target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>)
----------------
Just wanted to let you know that using `$<TARGET_OBJECTS:...>` in anything other than `add_library` and `add_executable` wasn't added until cmake 3.9, so I'm unable to configure lldb using the officially supported cmake 3.4.3 version.

Btw, I use cmake 3.4.3 locally so I don't unintentionally use new unsupported features to the clang/llvm cmake files.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55653/new/

https://reviews.llvm.org/D55653