[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 14 17:06:21 PDT 2019


xiaobai added a reviewer: sgraenitz.
xiaobai added a comment.

Seems alright to me. I'd like to see 1 message changed from a STATUS to a WARNING though.



================
Comment at: lldb/cmake/modules/LLDBConfig.cmake:131
   if ("${PYTHON_HOME}" STREQUAL "")
-    message("LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME.  Python support disabled.")
+    message(STATUS "LLDB embedded Python on Windows requires specifying a value for PYTHON_HOME.  Python support disabled.")
     set(LLDB_DISABLE_PYTHON 1 PARENT_SCOPE)
----------------
Please make this a warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63370/new/

https://reviews.llvm.org/D63370





More information about the lldb-commits mailing list