[Lldb-commits] [PATCH] D62743: Add color to the default thread and frame format.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 14 13:48:21 PDT 2019


JDevlieghere marked 4 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Core/Debugger.cpp:124
+#define FILE_COLOR "${ansi.fg.yellow}"
+#define STOP_COLOR "${ansi.fg.red}$"
+
----------------
aprantl wrote:
> Thanks, but I was thinking more about something that could be replaced dynamically to support dark and light terminals in the same LLDB binary. Int hits form, this probably doesn't add much because ...
As discussed offline, I think it's better to have fixed colors (but not things like black and white) and let the user's color scheme deal with their interpretation. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62743/new/

https://reviews.llvm.org/D62743





More information about the lldb-commits mailing list